Enable & pass dbt-adapter-tests #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataders
commented
Sep 29, 2020
Comment on lines
+48
to
+65
| {% macro sqlserver__drop_schema(relation) -%} | ||
| {%- set tables_in_schema_query %} | ||
| SELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES | ||
| WHERE TABLE_SCHEMA = '{{ relation.schema }}' | ||
| {% endset %} | ||
| {% set tables_to_drop = run_query(tables_in_schema_query).columns[0].values() %} | ||
| {% for table in tables_to_drop %} | ||
| {%- set schema_relation = adapter.get_relation(database=relation.database, | ||
| schema=relation.schema, | ||
| identifier=table) -%} | ||
| {% do drop_relation(schema_relation) %} | ||
| {%- endfor %} | ||
|
|
||
| {% call statement('drop_schema') -%} | ||
| drop schema if exists {{ relation.without_identifier().schema }} | ||
| IF EXISTS (SELECT * FROM sys.schemas WHERE name = '{{ relation.schema }}') | ||
| BEGIN | ||
| EXEC('DROP SCHEMA {{ relation.schema }}') | ||
| END |
There was a problem hiding this comment.
@mikaelene here is the change we made that @jtcohen6 mentioned here dbt-msft/dbt-sqlserver#54 (comment).
In our adapters we never use drop_schema(), nor does dbt-integration-tests so we never new it was problematic.
dataders
commented
Oct 26, 2020
Comment on lines
+5
to
+12
| {% macro sqlserver__get_columns_in_query(select_sql) %} | ||
| {% call statement('get_columns_in_query', fetch_result=True, auto_begin=False) -%} | ||
| select TOP 0 * from ( | ||
| {{ select_sql }} | ||
| ) as __dbt_sbq | ||
| {% endcall %} | ||
| {{ return(load_result('get_columns_in_query').table.columns | map(attribute='name') | list) }} | ||
| {% endmacro %} |
There was a problem hiding this comment.
@mikaelene, this is one macro we had to overwrite. perhaps this is the error you were seeing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is blocked by dbt-labs/dbt-adapter-tests#7
changes:
DROP SCHEMA ... CASCASEto drop all views & tables on a given schema before dropping the schema itself. this was never an issue previously as it is only needed for the test suite and no materialization (that I know of) uses it.get_columns_in_querybecause T-SQL does not supportLIMIT.sqlserver__check_schema_exists():(database, schema)to(information_schema, schema)sqlserver__drop_schema:(database_name, schema_name)torelationFYI (@mikaelene) many of these changes will also need to be propagated upstream to
dbt-sqlserver. @NandanHegde15 and I are happy to help with that.